zlatinb
eyedeekay: re GPLv2+CE compliance
zlatinb
I'm doing something very different from you in the Mac bundle
zlatinb
we should go over what approach is the correct one, or if both are ok
eyedeekay
I see your last change was to bundle all the licenses from i2p.i2p into the Resources directory, I want to double check that I get all that installed with NSIS
eyedeekay
But I'm not quite sure what we are doing very differently otherwise?
zlatinb
afaik you're generating an License-index file, whereas I'm just copy-pasting the LICENSE.txt from i2p.i2p
zlatinb
and then cat >> to it a blurb about GPLv2+CE (see previous commit)
zlatinb
the assumption being that zzz has done his homework on license compliance in the LICENSE.txt file and it's ok to just build on top that lol
zlatinb
also wrt maintainability it's better to rely on a single source of truth so to speak
zzz
eyedeekay, re: SAM exception - if you have questions about code, this is a good place to ask, before you check in changes
zzz
putting speculation and ponderings into check comments is neither good practice nor a good look for the project
zzz
translators: console news release announcement entry pushed to transifex, please translate by Noon UTC Monday
eyedeekay
Ack. I guess my only question is whether there is another way which would have worked? I tried re-creating SAMException on the Android app in a scope I could use it, but it didn't work
eyedeekay
zlatinb: I see... LICENSE.index is mostly there to be picked up by NSIS, since NSIS shows one license page by default the purpose of concatenating them is to make sure all licenses show up in the NSIS license page
eyedeekay
Individual license files for bundled software(the files that get combined) are also installed by the installer
zzz
eyedeekay, no, that's the correct change, it's the speculation that was wrong. It wasn't public before because it was never thrown from a public class, afaik, it was internal only
zzz
there's nothing wrong with public methods in a package private class, it wasn't a bug, it's just that it wasn't part of the public API before
zzz
so let's make changes based on solid understanding, not add checkin comments that make it look like we're flailing coder hacks around here :)
eyedeekay
Thanks for helping clarify that for me. I guess I got the right answer, but with like 25% right reasoning. Good thing I'm making progress in TIJ
eyedeekay
OK I've got some improvements to the licensing stuff inbound, should make it much less confusing, there were a few issues I hadn't identified with it until I went through it all end-to-end today, nothing huge but I'll document it in the release section of the readme
dr|z3d
no resolution for git.idk.i2p/i2p-hackers/i2p.i2p/-/issues/351 yet, zzz?
zzz
dr|z3d, no