RN
by the way, the proper fix for java18 javadocs is to change <h4> and </h4> to <H1> and </H1> and that should work the same in java8
mesh
really
mesh
that's freaking sucks
mesh
javadoc wants html tags capitalized?
RN
no
RN
I messed up the caps
RN
but you can't have <H4> if you didn't have <H3> prior
RN
so H1 it should be
mesh
ah
mesh
yeah I was gonna say I use lowercase tags in javadoc.html all the time
RN
hehe
RN
it took me a couple years to websearch the WHY
RN
heheh
RN
but now that I'm making dev builds again... I poked my head into the updaterWithJavadocs again
RN
(my previous fix was to just delete those tags, but H1 is better)
mesh
interesting
mesh
has anybody gotten around to building i2p with something newer than java8?
RN
I'm assuming earlier java doesn't check as completely
RN
yes
mesh
RN: very interesting
mesh
RN: do you have docs on how you produce jdk18 builds?
RN
I have a script... moment...
RN
it does more than just build
mesh
I need to dig up my previous docs. I think I was close to building i2p with java8 at the beginning of summer, way back in june
RN
I'm actually going to switch to building with jdk8 before I make the updates section on my site live
RN
for maximum compatibility
mesh
jdk8 will never die unfortunately
mesh
after humans blow themselves up it'll just be cockroaches and they'll probably use jdk8
RN
heheh
zzz
eyedeekay, thanks for the approvals and merges... now I have questions :)
eyedeekay
zzz pong re: questions
zzz
good morning, how goes it?
zzz
just some simple process q's
eyedeekay
Keeping busy, you?
eyedeekay
Go for q's
zzz
- we didn't talk about it, but I expected you'd approve my MRs and then I'd merge them... were you just doing me a favor, or are you responsible for all merging?
eyedeekay
Didn't have a hard and fast rule but I can do it that way
zzz
b/c I may have final tweaks or want to fixup the merge commit msg
zzz
but it may depend on the next q too:
zzz
- Am I allowed to checkin anything directly to trunk (besides merges), even something minor? Or must everything go thru an MR?
eyedeekay
If it's tiny go ahead and add it to trunk, I do the feature-branch thing because it's easier for me to work through the big diffs but if the diff fits in an 80x40 terminal it is probably not worth it
zzz
- am I allowed to add entries to history.txt and/or bump the build rev? Or, it appears you're only updating history.txt at release time, is that the new system?
eyedeekay
Updating at the end is a bad system I need to get out of the habit of using, feel free to bump history, but ask about build rev
zzz
- ok, so I'd like to merge the MR you approved last night, then add that one and all my MRs that you merged to history.txt, and bump to -3, and push that directly. OK?
eyedeekay
Sure go ahead
zzz
great, that's all my q's for now. If I'm not sure what to classify as 'tiny' in the future I'll ask. Thanks!
eyedeekay
You're welcome, np
zzz
one more thing eyedeekay, I need your review of my SAM MR in the next couple days because I promised to get back to bitcoin by the end of the month :)
eyedeekay
Ack, will have it done today
zzz
thanks