zzz
eyedeekay,
zzz
+ // ToDo: Clarify the following log message.
zzz
+ // This message is phrased in a manner that draws attention, and indicates
zzz
+ // the possibility of a problem that may need follow-up. But examination
zzz
+ // of the code did not provide insight as to what is being verified,
zzz
+ // and what is failing. This message will be displayed unconditionally
zzz
+ // every time a DSRM is handled here.
zzz
may I provide that insight, fix the code, and remove those comments?
zzz
FloodfillVerifyStoreJob, which is currently broken
eyedeekay
Yes please go ahead
zzz
there's a little in the javadoc and a lot more here i2p-projekt.i2p/en/docs/how/network-database
zzz
tl;dr FVSJ verifies a previous store to a ff by querying another ff close to the previous target, to see if he flooded it
zzz
I just set traps for every place you lookup a RI in a subdb and I quickly snared FVSJ
zzz
I'm working on it, it's a little bit of a mess but I'll figure it out
zzz
did you test with RI verifies enabled which is not the default? because there's log changes all in here about RI verifies
zzz
so it seems like you were chasing problems in FVSJ but just gave up
zzz
correction, we do verify RI stores early
zzz
woot, trap caught another offender
zzz
InboundMessageDistributor which I haven't reviewed yet but has a ton of changes
eyedeekay
I stopped seeing them actually but never knew why
eyedeekay
Lost connection for a little bit just got the scrollback let me see if can follow it
eyedeekay
IBMD was where a lot of the subDb action happened
zzz
I should have an MR tomorrow
zzz
what code are you working in today?
eyedeekay
Somehow managed to break all my clients with that this morning so it will be a little longer
zzz
with what?
zzz
broke how?
eyedeekay
None of my standard clients would connect to the configured destination after about 5 or 6 minutes
eyedeekay
Or IRC
eyedeekay
I am not sure what was going on but it survived restarting and I'm still trying to get something to show up in the log
eyedeekay
As floodfill
eyedeekay
Right now
zzz
ok. I'm exclusively non-ff to date.
eyedeekay
I will try switching and see if that changes something, hadn't yet
zzz
just take a 2nd router and start running dev builds onit
zzz
but at least for now we have it covered between the two of us
eyedeekay
zzz I'm going to merge !140, there are a couple more unused functions after the netDb reverts which I'll get in my unused function cleanup MR
zzz
ok thx