eyedeekay
Extension bugfix pushed to mozilla, bundle happens after their process finishes
zzz
eyedeekay, I think the gentoo MR is madness, holler if you'd like to discuss
eyedeekay
zzz sure I've got time now if you like, I'm sort of digging through the complications now, since it's a buildsystem thing I figure it's going to touch stuff that tharvik might not see right away
zzz
read what I just put in there then let me know
eyedeekay
Lol my enthusiasm is for the principle if not the MR itself, 89 files is indeed a huge diff, and breaking our packages would indeed be a nightmare
zzz
look
eyedeekay
You're right of course
zzz
packagers are opinionated people and they have the rules they're working under. But they don't give a crap about any other packagers
zzz
from past readings of threads/bugs this guy is on, sounds like he's on an odd quest to get rid of every vendored line of code
zzz
even though gentoo doesn't have equivalent packages for any of he wants to rip out
zzz
so rather than tackle that he wants to redesign the whole thing to his liking
eyedeekay
I must say I know almost nothing of gentoo package maintenance and management so I can't offer any perspective on why he thinks this approach is better than the other
zzz
me either
zzz
but what downstream sends a 90-file patch upstream to make _their_ life better? why can't he just maintain that patch in gentoo if that's how to bend i2p into his worldview?
dr|z3d
I thought tharvik was some build subsystem, and then I rechecked the MR. *chuckle*
zzz
you also mayh not know much of our build system, which I mostly maintain, and all the deb stuff I had to do panic-mode after kytv1 vanished ((
dr|z3d
10 commits, 89 files changed. seriously?
dr|z3d
what do we get? :)
eyedeekay
Yeah, when you put it like that you're obviously right the patch itself as it stands is absolutely madness
dr|z3d
apart from a severe case of headache.
zzz
this is the guy that was setting i2p.app.dir etc each to something different and it broke a bunch of stuff
zzz
sure there's some value in trying to keep stuff like tomcat up-to-date via maven but who's going to do all the testing
zzz
I'd like to have a list of dependencies we bundle that are in maven but not debian
zzz
the list in debian-alt/doc/dependencies.txt is where you'd start
zzz
dr|z3d, other than the headache, not much but a lot of trouble, regressions, testing, ...
dr|z3d
yeah, that's what it looks like from here.
dr|z3d
and as you mentioned, they don't have i2p in the official gentoo repos either, do they?
eyedeekay
Yeah. Maybe there's a better, less invasive way to accomplish some parts of it but I'm definitely not going to ack this version, probably never will
zzz
if Gentoo's, or his, rules are No Line Of Code Shall Be Vendored, fine, but that doesn't make it our problem
zzz
link from stats dashboard to the gentoo pkg
dr|z3d
well, there's an easy answer to all of this.
dr|z3d
do your own fork, and make sure it's synced with upstream.
eyedeekay
At least, not an 89-files-at-a-time version
eyedeekay
I mean if it's just buildsystem stuff it's not even a fork, really, it's like 10% of the work to embed it in something else
zzz
let's not be immediately over-the-moon encouraging to MRs like this, we want to be welcoming but lets not overdo it
dr|z3d
"on reflection, and after much consideration, thanks but no thanks"
zzz
nothing to do with embedding. He has a philosophy of how Things Should Be and the MR is to make it happen
zzz
In years and years we never got a single MR/PR/bug report/fix request from mhatta. And he was working with us! He just changed/patched whatever didn't meet debian rules.
eyedeekay
Debian provides the debian/patches directory for that, maybe if gentoo has an equivalent it can apply the patch in the MR
eyedeekay
Perhaps that's the path of least resistance for all concerned
dr|z3d
sure, that's a decent idea. top level gentoo dir with everything required to build for gentoo.
eyedeekay
And the patch he needs apparently already exists as a by-product of this MR
dr|z3d
and probably the same commands in the top-level build.xml file as per debian. ant gentoo gentoo-clean gentoo-howto
eyedeekay
could be
dr|z3d
if that's the only stuff that gets changed, and nothing else in the tree, then there shouldn't be any disruption or regressions.
zzz
all our packaging system and licensing rules are with an eye to getting back into real debian someday and following their rules. Gentoo doesn't even have all the packages that debian does, I don't know what their rules are, and I suspect this guy has his own set of rules
zzz
yanking everything from maven is interesting, but we don't really do maven
zzz
and, btw eyedeekay, we vendor a LOT of stuff into the maven packages that should really be replaced by maven dependencies instead, if we cared, but we probably don't
zzz
and that might destabilize the android build too
zzz
I'm using 'vendor' == 'bundle' but from the title of his MR that may not be correct
eyedeekay
It probably would, the android build pulls things in a pretty specific way that requires a very old plugin