@eyedeekay
&kytv
&zzz
+R4SAS
+RN
+RN_
+dr|z3d
+hk
+orignal
+postman
+wodencafe
Arch
DeltaOreo
FreeRider
FreefallHeavens
Irc2PGuest19353
Irc2PGuest22478
Irc2PGuest48042
Irc2PGuest64530
Irc2PGuest77854
Nausicaa
Onn4l7h
Onn4|7h
Over
Sisyphus
Sleepy
Soni
T3s|4_
Teeed
aargh3
acetone_
anon4
b3t4f4c3
bak83_
boonst
cumlord
dr4wd3
eyedeekay_bnc
hagen_
khb
not_bob_afk
plap
poriori_
profetikla
r3med1tz
rapidash
shiver_1
solidx66
tr
u5657
uop23ip
w8rabbit
weko_
x74a6
zzz
eyedeekay, I assume you don't want to mess with it at this point, but the LS debug page is even more borked now
zzz
It's only showing our local LSes, not the others; and there's numerous HTML errors in the view-source
eyedeekay
I see it, I think it's too late to mess with it being day before release but re: the local ls's it's a backward conditional
dr|z3d
backward conditional. *chuckle*
zzz
I doubt thats the cause of the html errors though
zzz
always ^U and eyeball the html source after big changes
zzz
I also found at least one new tagged string you added, you told me there weren't any
eyedeekay
Crap, I thought I had only re-used them
eyedeekay
Specifically tried to only re-use them
zzz
this whole thing was too late and not tested well enough, that's the recipe for regressions
eyedeekay
Ack, I should have made time for it sooner in the cycle
zzz
also, did you say you were updating your plugiun cert? because it's not in here
eyedeekay
That news changed actually, so, hankhill19580_at_gmail_dot_com is going away retired forever because I over-wrote it and don't have the old key anymore
eyedeekay
But I have another set of plugin keys I was using for Java plugins idk_at_mail_dot_i2p
eyedeekay
So I changed my Go plugin signing tool to allow me to use the keys generated with Java instead of the keys generated with Go
zzz
ok well you haven't made any changes w.r.t. that in trunk
eyedeekay
So the old keys are staying in for one more cycle while I get the Go plugins signed with the Java keys
zzz
well you can leave the old key in until it expires, unless you're resigning all your plugins
zzz
but shouldn't you add your new key?
zzz
still not clear quite what your plan is
eyedeekay
Go plugins are all going to be re-signed with idk_at_mail.i2p's keys
zzz
so why not checkin that cert?
eyedeekay
Because I thought it was already there, but I think I was in the wrong branch
zzz
since you did reference it in the console news, you may wish to fix your 'reversed conditional' if it's that easy and you have time to test
zzz
in the future, I suggest you do not reference stuff hidden behind advanced config (like netdb search) in the console news, it will frustrate people that go looking for it
zzz
definitely no idk cert in trunk
zzz
review complete, no other issues
eyedeekay
Yeah I caught it today too I was just looking at the fix, it's on like 835 in NetDbRenderer
eyedeekay
should be: if (!ls.getHash().equals(myLeaseSet.getHash())) { instead of if (ls.getHash().equals(myLeaseSet.getHash())) {
eyedeekay
*line 835
zzz
ok. if you had hollered for testers after your last fix maybe we could have caught it sooner