T3s|4
o/ dr|z3d - did 92 slaughter additional turtles?
dr|z3d
hello T3s|4. see git.skank.i2p/i2pplus/I2P.Plus/commits/branch/master for info.
dr|z3d
tldr: no, no turtles were harmed in the making of that revision.
dr|z3d
zzz: are you intending to implement a file browser for your add torrent MR?
dr|z3d
otherwise I'm not sure it adds much value when you can just drop a torrent into the snark dir, unless it supports downloading to the same dir as the torrent?
zzz
no
zzz
agreed it's a modest feature but worth it imho
zzz
and it fixes something I didn't know how to do 15 years ago
dr|z3d
so it uses the torrent in situ and downloads to the snark dir, copies the torrent to the snark dir, or downloads to the location of the torrent?
zzz
copies
dr|z3d
ok, so it does appear to use the OS file manager.
zzz
it's just browser's <input type=file> same as we use everywhere
zzz
nothing special
dr|z3d
yeah, that was what I was asking, I overlooked the input type reviewing the code, but now I've got it running I see.
dr|z3d
so you'll probably want to tooltip the input as per the from URL input, indicating that the torrent will be copied to the configured download dir.
zzz
maybe
dr|z3d
From local torrent file.. "local" is probably superfluous here.
zzz
i was 50/50 on that
dr|z3d
it's a file browser, by definition it's local. :)
zzz
yup
dr|z3d
so, local, superfluous.
zzz
2 weeks to tag freeze...
dr|z3d
Looking at it, "From" is probably also superfluous.
dr|z3d
I mean, it's not adding from a torrent file, it's adding a torrent file directly.
zzz
"Torrent file" is already tagged so lets do that
dr|z3d
perfect
dr|z3d
will probably add a script to change the file input display if a file is dragged onto the input to reflect that drag and drop is possible.
zzz
i don't think you can drag onto a file input
dr|z3d
you can. try it.
dr|z3d
should work without issue for local files.
zzz
yeah I was wrong. It works without my dnd.js, which interferes
dr|z3d
never got around to doing it, low priority, but for home page links, drag drop (and subsequent copy to nominted folder) for icons I always thought would be handy, given the only way to configure icons right now is by diving into router.config
zzz
now that I'm absolutely sure what's possible and what's not, I'll probably take another run at DnD for 2.5.0
dr|z3d
were you making the entire UI a drag and drop zone?
zzz
I forget, I'm not in it right now
dr|z3d
I don't recall the implementation, only tried it once.
zzz
but in no way in any of the half dozen APIs can you ever get the full path
zzz
so that brings clarity