IRCaBot 2.1.0
GPLv3 © acetone, 2021-2022
#saltr
/2024/05/24
~dr|z3d
@RN
@RN_
@StormyCloud
@eyedeekay
@orignal
@postman
@zzz
%Liorar
+FreefallHeavens
+Xeha
+bak83_
+cumlord
+hk
+poriori
+profetikla
+uop23ip
Arch
DeltaOreo
FreeRider
Irc2PGuest10850
Irc2PGuest19353
Irc2PGuest23854
Irc2PGuest46029
Irc2PGuest48064
Meow
Nausicaa
Onn4l7h
Onn4|7h
Over
T3s|4__
acetone_
anon4
anu
boonst
enoxa
mareki2pb
mittwerk
plap
shiver_
simprelay
solidx66
u5657_1
weko_
dr|z3d does this look saner, or am I making the same mistake here?
dr|z3d b32 = reader.readLine();
dr|z3d if (b32 == null) {return;}
zzz same
dr|z3d yeah, figured.
dr|z3d so, totally pointless then, as you say. this should cover it: while((b32 = reader.readLine()) != null) {
dr|z3d well, not totally pointless, as it prevents the issue from triggering, but not the correct fix.
dr|z3d what about checking the filesize instead?
dr|z3d int fileLength = (int) file.length();
dr|z3d if (fileLength == 0) {return;}
zzz better
zzz but the reason for a ticket was that this is low priority, not for today, so if you want my analysis you'll have to sit tight ))
dr|z3d sure, I don't think it's something that'll affect most people.
dr|z3d if there's no file at all, non-issue. only zero length file, or presumably a file containing no b32s.
dr|z3d got a stacktrace zzz, bug report updated.