~dr|z3d
@RN
@T3s|4
@T3s|4_
@eyedeekay
@orignal
@postman
@zzz
%Liorar
%acetone
%snex
+FreefallHeavens
+Leopold
+Xeha
+ardu
+bak83_
+hk
+profetikla
+qend-irc2p
+r00tobo
+uop23ip
+weko
Arch
BubbRubb
Danny
DeltaOreo
FreeB
HowardPlayzOfAdmin
Irc2PGuest19950
Irc2PGuest41581
Irc2PGuest85438
Irc2PGuest95056
Meow
Onn4l7h
Onn4|7h
StormyCloud_
altonen
anontor
boonst
l337
maylay
not_bob_afk
not_human
poriori_
r00tobo[2]
shiver_
solidx66_
thetia
tr
u5657
zer0bitz
zzz
dr|z3d, would you like to help customize the Jetty 12 eepsite error page?
dr|z3d
> sure, zzz, we have one already in +, but maybe now's a good time to update it.
dr|z3d
> what are you working with right now? can you throw it up on stats.i2p?
zzz
we have ErrorServlet for console webapps and error.jsp/error500.jsp for the main routerconsole now
zzz
but nothing for eepsite
zzz
whats the file name of your eepsite error handler and I'll peek
dr|z3d
same as yours afaik.
zzz
we don't have one
dr|z3d
oh, one sec.
zzz
and I don't see one in plus either
dr|z3d
git.skank.i2p/i2pplus/I2P.Plus/src/branch/master/apps/jetty/java/src/net/i2p/servlet/ErrorServlet.java
zzz
yeah that's for the console
zzz
if you do have something for eepsites, it would have to be configured in jetty.xml, base-context.xml, or JettyStart.java
dr|z3d
git.skank.i2p/i2pplus/I2P.Plus/src/branch/master/apps/jetty/java/src/net/i2p/servlet/I2PDefaultServlet.java
dr|z3d
protected ContextHandler initContextHandler(ServletContext servletContext) {
dr|z3d
ContextHandler rv = super.initContextHandler(servletContext);
dr|z3d
_contextHandler = rv;
dr|z3d
ErrorPageErrorHandler errorHandler = new ErrorPageErrorHandler();
dr|z3d
errorHandler.addErrorPage(403, "/.resources/403.html");
dr|z3d
errorHandler.addErrorPage(404, "/.resources/404.html");
dr|z3d
rv.setErrorHandler(errorHandler);
dr|z3d
return rv;
dr|z3d
}
zzz
interesting
dr|z3d
I guess that's slightly better than horrific. :)
zzz
hadn't considered doing it that way
dr|z3d
there should be a fallback there in the event the files aren't found.
dr|z3d
if you look at the method above, there's also support for a global jetty-dir.css file.
dr|z3d
that _does_ have a fallback global default.
zzz
was not familiar with ErrorPageErrorHandler
zzz
I was just looking at overriding ErrorHandler
zzz
but having external resources looks nice
dr|z3d
sure, you can customize as you see fit then.
zzz
so ErrorPageErrorHandler extends ErrorHandler which is where I was at
dr|z3d
git.skank.i2p/i2pplus/I2P.Plus/src/branch/master/installer/resources/eepsite/docroot/.resources
dr|z3d
amuse yourself with the whitespace perfect nginx 404 option.
dr|z3d
been so long since I looked at error handling, I'm probably not going to be much help aside from pointing you at what I did :)
zzz
there's also a addErrorPage(from, to, uri) so you could do addErrorPage(405, 999, foo.html)
zzz
if you didn't want anything to fallback to the ugly version
dr|z3d
how does that work? we just add an inline fallback?
dr|z3d
(as per the fallback css)
dr|z3d
*fallback jetty-dir css.
zzz
it's just a default error page essentially
dr|z3d
we can do better than that.
dr|z3d
we can just check the file's in place, if not, present a slimmed down version of the 404/403.
onon_
dr|z3d, cake.i2p is down forever?
dr|z3d
onon_: hope not. itsjustme runs it, he's been awol for a while.
zzz
unfortunate because sharefile.i2p has vanished also
dr|z3d
there's also upload.arav.i2p
dr|z3d
not used it, but it's there.
dr|z3d
not sure it's desirable, but having an inline fallback allows for translated error strings.
zzz
yeah but we strip accept-language in the proxy, and you probably don't want to translate based on the server locale
dr|z3d
yup, that's what I was thinking. probably not desirable. better to make the error as global as possible. just a big 404 or whatever with a background graphic and a css container.
dr|z3d
(we can inline the css and a simple svg so the fallback is presentable).
zzz
I'm going to take the .resources idea and run with it
dr|z3d
10-4
dr|z3d
help yourself to the error page assets, I'll look at renovating those later.
zzz
thanks
dr|z3d
you're welcome. if you have any ideas for improvement on the visual side of things, give me a shout.
dr|z3d
I'll be swapping out the bitmap for an svg.
zzz
yeah, 40KB is a little heavyweight for an error page, not crazy but could be better
dr|z3d
agreed. we'll get it down to under 5KB, ideally before it gets gzipped.
zzz
remote search WIP for dr|z3d and postman and cumlord to play with git.idk.i2p/I2P_Developers/i2p.i2p/pulls/513
orignal
built and run i2psnark for haiku
zzz
nice
orignal
and more funny that it works
orignal
with i2pd's I2CP
dr|z3d
thanks, zzz
zzz
still hoping you can merge in and test the zzzot changes for UDP
orignal
proof
cumlord
zzz awesome 🤩
zzz
holler if you try it
zzz
but the latest api spec says limit of 10/minute, which is too low for type-as-you-go
zzz
don't know if implemented though
cumlord
10/min? Oh man I gotta look at that again posty reminded me I’m doing double pulls for some reason